putting the css all in style-rtl.css is a good idea.

There are some mistakes in your CSS that breaks the style in ltr, , it is no big deal, I am fixing them before I commit it to the repository.

Whenever you have more than one selector separated by commas, you need to have the html[dir='rtl'] again after each comma or else it also affects ltr. It is very noticeable in the menu of artisteer-greenlagoon when your changes were applied and then I changed  back to ltr culture.

For example where you had:

html[dir='rtl'] h1, h1 a, h1 a:link, h1 a:visited, h1 a:hover{text-align:right;}

it really should be:

html[dir='rtl'] h1, h1 a,
html[dir='rtl'] h1 a:link,
html[dir='rtl'] h1 a:visited,
html[dir='rtl'] h1 a:hover{text-align:right;}

every selector must start with html[dir='rtl']

Best,

Joe

Hi Ahmed,

I have committed it to the repository just now. However, I commented it out in style.config so you will need to un-comment it to use the style-rtl.css. Note that I also moved the images into images-rtl rather than nested in the other images folder.

The style-rtl.css still needs some work, when using rtl the menu offset for the flyout sub menus is not right (it might be something in the artisteer menu javascript if you don't find it in CSS), also headings have the icon overlapping the heading text.

I think it is nice to be able to support this kind of skin that can adapt to either ltr or rtl but I think most people will not want to do that, so the default config setting remains as 

<add key="AdaptHtmlDirectionToCulture" value="false" />

and I do not think we should include the style-rtl.css by default (but have it there commented out so people can find it and un-comment it if they want to) since it is not used when that setting is false and it is a significant amount of additional CSS and will make the CSS payload larger than it needs to be when not using it.

It is not a goal for me to have this ability in all skins we ship, but if you want to do that it is fine, but still it will be disabled by default and those who wish to use it will have to opt in to use it by enabling it.

Best,

Joe