Strange code in CacheHelper.cs

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

Please do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.

This forum is for discussing mojoPortal development

You can monitor commits to the repository from this page. We also recommend developers to subscribe to email notifications in the developer forum as occasionally important things are announced.

Before posting questions here you might want to review the developer documentation.

Do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.

This thread is closed to new posts. You must sign in to post in the forums.

3/12/2007 10:30:21 AM

Alexander V. Yushchenko

Total Posts 488

View Posts

Strange code in CacheHelper.cs

Doing some refactoring I found the following code:

if (HttpContext.Current.Items.Contains("CurrentPage"))
{
HttpContext.Current.Items["CurrentPage"] = currentPage;
}
else
{
HttpContext.Current.Items.Add("CurrentPage", currentPage);
}

Are there some reasons for not just

HttpContext.Current.Items["CurrentPage"] = currentPage;

?

3/12/2007 10:57:43 AM

Joe Audette

Total Posts 18439

View Posts

Re: Strange code in CacheHelper.cs

Hi Alexander,

I don't remember why I coded it that way but I agree in looking at it it seems it could be simplified as you suggest.

I will make that change here, if I don't notice any problems I will commit it to svn later today.

Best,

Joe

You must sign in to post in the forums. This thread is closed to new posts.