Hi all,

I noticed a problem with unsubscriptions from forums. Unfortunately, I don't have the time to attempt a patch right now, so I thought I'd at least point out the problem.

Reproduction steps:

1) Create a forum, and a post, and setup smtp

2) Subscribe to the _forum_ (not individual post)

3) Make a post, such that it sends you an email

4) Try to click on the link to unsubscribe from the _thread_ (not the forum)

5) You get this nasty: "Unsubscribe FAILED! An error occurred when attempting to stop notifications for a thread. Please contact the site administrator." 

Totally unexpected until I read the fine print -- that one is for FORUM unsubscription and one is for THREAD unsubscription.   It makes sense (to me, as a programmer) why this is happening -- I was subscribed to the forum and not the thread, so there was no thread subscription to remove.  But this will thoroughly confuse our users -- they'll think that there's some problem with the system, and won't correctly distinguish between the two links in the email.

It seems to me that if you try thread unsubscription when subscribed to the forum, there would be an exclusion entered into the database, or at least that a message would come up saying something like "You are not subscribed to this thread, but you are subscribed to this forum.  To unsubscribe from the forum, click here."  Also, if the user is not subscribed to a thread or forum, then a link to unsubscribe should not be sent.

My mojoportal is at revision 35779f73ecb5 (2010-09-08 11:02:46 -0400 (6 weeks ago)).  It would be a bit of a pain to upgrade right now.  I did glance through the incoming changesets to see if this might have been fixed already, but didn't see anything.

Cheers,

Erich