Hi Joe,

Not sure if already logged but the page size setting on the feed manager module does not work as of 2.3.4.4 (im using changeset ee3aed3985e2).

Looking at the source for FeedManagerModule, pageSize does is not set from the FeedManagerConfig.

My solution was to remove the pageSize private field form FeedManagerModule and then changed BindRepeater method like so:

PagedDataSource pagedDS = new PagedDataSource();

pagedDS.DataSource = entries;
pagedDS.AllowPaging = true;

var pageSize = config.PageSize; //pageSize variable is used in rest of method so this was easiest way

pagedDS.PageSize = pageSize;
pagedDS.CurrentPageIndex = pgrRptEntries.CurrentIndex - 1;
 

After making this change, paging works as expected.

Cheers,

Ben

Great stuff.

While i've got you then, I am unable to display module icons. It is a custom skin and I am not hiding them with my css, the markup is not actually rendered at all. Trying to look through the ModuleTitleControl code now to see where/how this is rendered but not having much luck,

Thanks,
Ben

I mean when I go to the settings of a specific module, I can choose an icon on the general settings tab. I assumed this would display an icon next to the module title. Is this not the case?

Okay, my bad.

Guess I will just a custom css class to the module and override the module title style.

Thanks for the clarification although I do think it would be nice to be able to set icons on the title from the settings.