Hi Alexander,
Can you try modify the procedure as follows and then see if performance is better? Now it is all in a single statement.
ALTER PROCEDURE [dbo].[mp_ModuleSettings_SyncDefinitions]
AS
UPDATE ms
SET ms.RegexValidationExpression = mds.RegexValidationExpression,
ms.ControlSrc = mds.ControlSrc,
ms.ControlType = mds.ControlType,
ms.SortOrder = mds.SortOrder,
ms.HelpKey = mds.HelpKey
FROM mp_ModuleSettings ms
JOIN mp_Modules m
ON ms.ModuleID = m.ModuleID
JOIN mp_ModuleDefinitionSettings mds
ON ms.SettingName = mds.SettingName
AND m.ModuleDefId = mds.ModuleDefId
GO
It should be much faster I think.
Best,
Joe