Hi Bo,
I think you should subscribe to the svn commit notification so you can know about changes committed to svn
http://forge.novell.com/mailman/listinfo/mojoportal-svncommits
I've made some changes recently in relation to SiteSettings in svn /branches/joesandbox2
However I still think SiteSettings should be created in Application_BeginRequest and added the http context this way it is available to all users controls throughout the request duration.
I added the SiteSettings.GetCurrent a while back becuase I found myself writing the same code in many places
if(Context.Items["SiteSettings"] != null)
{
siteSettings = (SiteSettings) Context.Items["SiteSettings"];
}
It doesn't seem unreasonable to me that SiteSettings.GetCurrent can return null
If it returns null in your page your should try and find out what happened and why it did not get added to the context at the beginning of the request.
I think we should first look into implementing page caching before we look at caching SiteSettings