Hi all,

I'm not sure if this is exactly the right place to be posting this, but I guess it's worth a shot.

I am working on creating a custom module which needs to send email.  I am having issues with the following code, getting an "Object reference not set to an instance of an object" error, which I think means that something isn't instantiated.  However, I can't find in here what's not.  All the variables in the MailMessage() parameters are set right above the try statement.

If someone could look at this and see what I might be missing, that would be great.

Thanks,

--------------------------------



try

{

//MailMessage msg = new MailMessage(yourEmail, friendEmail, subject, html);

MailMessage msg = new MailMessage("millicanms18@gmail.com", "millicanms18@uww.edu", "test", "test");

msg.IsBodyHtml = true;

SmtpClient smtp = new SmtpClient();

smtp.Host = mailServer;

smtp.Port = 587;

smtp.Send(msg);

msg.Dispose();

}

catch (Exception ex)

{

lblMessage.Text = ex.InnerException.Message;

lblMessage.Visible = true;

}

It's not clear in your code if the mailServer variable has been initialized.

Also you have not set user or password credentials on the smtpClient. Also you have specified Html but did not pass in html message body.

Actually we have built in helper methods to make it easier to send email. Here is an example snippet from our contact form.

using mojoPortal.Net; (you will need to add a project reference)

try

{

Email.SendEmail(

SiteUtils.GetSmtpSettings(),

siteSettings.DefaultEmailFromAddress,

txtEmail.Text,

Settings["ContactFormEmailSetting"].ToString(),

string.Empty,

string.Empty,

txtSubject.Text,

message.ToString(),

true,

"Normal");

 Hope it helps,

Joe

}

catch (Exception ex)

{

log.Error(ex);

}

Hope it helps,

Joe

In the example from the contact form

using log4net; //(must set a dll reference from _libs folder)

private static readonly ILog log = LogManager.GetLogger(typeof(ContactForm));

Hope it helps,

Joe

Even if there is no error there can be no guarantee that an email is delivered and it is not a good idea to bother end users with concern about whether the smtp is configured correctly. That may be a concern for a site owner or developer but the site owner should check the logs and once smtp is configured correctly you will rarely ever have a problem.

If you think those methods should throw exceptions that must be handled by UI code then you could write your own email helper class to do that for your custom features.

Best,

Joe