LoadSettings in GalleryImageEdit.aspx

This is the place to report bugs and get support. When posting in this forum, please always provide as much detail as possible.

Please do not report problems with a custom build or custom code in this forum. If you are producing your own build from the source code and have problems or questions, ask in the developer forum, do not report it as a bug.

This is the place to report bugs and get support

When posting in this forum, please try to provide as many relevant details as possible. Particularly the following:

  • What operating system were you running when the bug appeared?
  • What database platform is your site using?
  • What version of mojoPortal are you running?
  • What version of .NET do you use?
  • What steps are necessary to reproduce the issue? Compare expected results vs actual results.
Please do not report problems with a custom build or custom code in this forum. If you are producing your own build from the source code and have problems or questions, ask in the developer forum.
This thread is closed to new posts. You must sign in to post in the forums.
10/20/2008 9:31:45 AM
mjohn
Gravatar
Total Posts 59
View Posts

LoadSettings in GalleryImageEdit.aspx

Hi, joe

Below four Setting keys' suffix  "Label" is Unnecessary.

private void LoadSettings()
{

......

webImageHeightSetting = WebUtils.ParseInt32FromHashtable(
moduleSettings, "GalleryWebImageHeightSettingLabel", -1); //GalleryWebImageHeightSettingLabel-> "GalleryWebImageHeightSetting"

webImageWidthSetting = WebUtils.ParseInt32FromHashtable(
moduleSettings, "GalleryWebImageWidthSettingLabel", -1); //GalleryWebImageWidthSettingLabel -> "GalleryWebImageWidthSetting"

thumbNailHeightSetting = WebUtils.ParseInt32FromHashtable(
moduleSettings, "GalleryThumbnailHeightSettingLabel", -1); // GalleryThumbnailHeightSettingLabel-> "GalleryThumbnailHeightSetting"

thumbNailWidthSetting = WebUtils.ParseInt32FromHashtable(
moduleSettings, "GalleryThumbnailWidthSettingLabel", -1);  //GalleryThumbnailWidthSettingLabel->"GalleryThumbnailWidthSetting"

......

}

Thanks!

10/20/2008 12:09:11 PM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: LoadSettings in GalleryImageEdit.aspx

Hi,

Yes, if I were building this feature today I would name those settings as you suggest but for backward compatibility with existing installations it is best to leave them alone now.

The setting name serves as both the key for the setting in ModuleSettings but also for the resource label key. So, early on in the project when this was implemented I hadn't thought through the naming convention as well. But since these settings already exist in the wild its best not to rename them now.

Best,

Joe

10/20/2008 7:54:32 PM
mjohn
Gravatar
Total Posts 59
View Posts

Re: LoadSettings in GalleryImageEdit.aspx

Hi, joe

This is a bug, If don't change these keys, the below fours settings

"humbnail Height"
"Thumbnail Width"
"WebImage Height"
"WebImage Width"

in

image gallery setting of a gallery feature will not take effect.

Thanks!

10/21/2008 5:53:47 AM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: LoadSettings in GalleryImageEdit.aspx

Thanks! I see the light now, you are right. I will make the same change here.

Best,

Joe

You must sign in to post in the forums. This thread is closed to new posts.