Joe,

In the SharedFiles module, when you delete a folder, all the files inside it and the sub-folders remain in the DB and on the disk. The method that should do the job is there but not implemented yet. Here is the way I implemented it :

File: SharedFileFolder.cs

public void DeleteAllFiles(String sourcePath)
{
// TODO: implement

IDataReader reader;
reader = SharedFile.GetSharedFiles(ModuleId, FolderId);
while (reader.Read())
{
SharedFile sharedFile = new SharedFile(ModuleId, Convert.ToInt32(reader["ItemID"]));
sharedFile.Delete(sourcePath);
}
reader.Close();

reader = SharedFileFolder.GetSharedFolders(ModuleId, FolderId);
while (reader.Read())
{
SharedFileFolder folder = new SharedFileFolder(ModuleId, Convert.ToInt32(reader["FolderID"]));
folder.DeleteAllFiles(sourcePath);
SharedFileFolder.DeleteSharedFileFolder(Convert.ToInt32(reader["FolderID"]));
}
reader.Close();

}

As you will notice, I had to change the signature of the method so you will also have to adjust the call to it in the method DeleteItem of the file SharedFiles.ascx.cs .

Thanks

Jean-Michel

Joe,

I'm using MSSQL,MySQL exclusively so I forget easily about other DBs limitations; thanks for bringing that point. Since I only need the IDs of the files and folders, I did put them in ArrayLists while I am looping for the deletes. I think that this is more lightweight than using datatables and it leave the code localised in the same method.
Here is my new version :

public void DeleteAllFiles(String sourcePath)
{
// TODO: implement

ArrayList folders = new ArrayList();
ArrayList files = new ArrayList();
IDataReader reader;

reader = SharedFile.GetSharedFiles(ModuleId, FolderId);
while (reader.Read())
{
files.Add(Convert.ToInt32(reader["ItemID"]));
}
reader.Close();

reader = SharedFileFolder.GetSharedFolders(ModuleId, FolderId);
while (reader.Read())
{
folders.Add(Convert.ToInt32(reader["FolderID"]));
}
reader.Close();

foreach (int id in files)
{
SharedFile sharedFile = new SharedFile(ModuleId, id);
sharedFile.Delete(sourcePath);
}

foreach (int id in folders)
{
SharedFileFolder folder = new SharedFileFolder(ModuleId, id);
folder.DeleteAllFiles(sourcePath);
SharedFileFolder.DeleteSharedFileFolder(id);
}
}

Regarding your concern about the versioning; I did not find a module setting that let you enable or disable it. It is always enabled and it brings a couple of other issues with the deletion of files. Here are my findings:
1- You cannot delete a file that has historic versions on it; when it tries to delete the row in the mp_SharedFiles table, it complains about a foreing key violation in the mp_SharedFilesHistory table. Unfortunately at that point the physical file is already destroyed; so you cannot even try to restore a previous version of the file. The only way to get out of that state is to cleanup manually the DB.
2- There is no way of removing individual historic versions of a file. Maybe this is by design but it is not very forgiving if you upload something by mistake. Plus because of problem #1 once you've uploaded a new version your file cannot be deleted.
3- If you are on the main page of the module (Sharedfiles.ascx) and you delete a file that has no history on it, it works fine; but if you go into the edit page and you try to delete the file with the delete button, the handler behaves differently, it creates an historic version of the file before the delete which puts you in the state of the problems mentioned above. Plus even if it would works , how could you restore the historic versions since the file does not exist anymore ?
My opinion is that when you delete a file , you should flush all the historical versions that comes with it.

By the way this is not a request for you to put time on this, I do not need this functionality ; I've just discovered these problems as I was modifying the module to include some user security on folders. If you want my help just let me know what route you want me to take for the fixes and I'll try to take a look at it when I have 2 minutes.

BTW I am really impressed with the quality of your code, plus attacking so many DBs with the same code base is quite an accomplishment. I am glad that I found Mojo :-).

Thanks
Jean-Michel