changes to core code?

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

Please do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.

This forum is for discussing mojoPortal development

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

You can monitor commits to the repository from this page. We also recommend developers to subscribe to email notifications in the developer forum as occasionally important things are announced.

Before posting questions here you might want to review the developer documentation.

Do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.
This thread is closed to new posts. You must sign in to post in the forums.
2/14/2013 4:28:06 PM
Jeff Duty
Gravatar
Total Posts 30
View Posts
www.CSBA.org

Information Technologies, Resources and Services

California School Boards Association

changes to core code?

Joe,

I'll be working on Tag Cloud and Private Messaging for an upcoming project. To do either correctly they need to be part of the core ( at lest that's my opinion ).  I'll send you all the code if you think this is something that could be included with the base install. I would rather not branch your code, but if its necessary I guess I can.

Jeff

2/14/2013 4:45:12 PM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: changes to core code?

Hi Jeff,

All I can promise is that I would review your code and consider it for integration once it is completed, I can't promise in advance whether it will be integrated, and it may take me a while to get to reviewing it due to my own work priorities. That said, those are ambitious features and potentially could be a great contributions. Once you have a vision for what those features would look like I'd be interested to have more details of what you plan to deliver.  For something like that you would need to have a contributor agreement on file as mentioned in the contribution guidelines. Anything in the core must support all the databases we support and must work in multi site installations. I may be able to help with other data layers if I like the rest of it and if you don't get too fancy with db platform specific things that may be harder to do in other platforms.

Best,

Joe

2/14/2013 5:17:48 PM
Jeff Duty
Gravatar
Total Posts 30
View Posts
www.CSBA.org

Information Technologies, Resources and Services

California School Boards Association

Re: changes to core code?

Joe,

Once I have my design docs done I'll post them so you can look them over. Any feed back would welcome. All the work I've done up till now has targeted MSSQL or Oracle, I don't have lots of experience hitting MySql or any of the other open source DBs. But I'll try and keep it a generic as possible so porting should be pretty simple. If you like the code we can deal with that then, no use worrying about that until you say yea or nay to the code.

Later,

Jeff

2/23/2013 1:39:20 PM
Jeff Duty
Gravatar
Total Posts 30
View Posts
www.CSBA.org

Information Technologies, Resources and Services

California School Boards Association

Re: changes to core code?

Joe,

Finally getting some time to put to designs and had a question for you. Normally I setup web services for some if not all my data pulls (I like a stateful feel). I realize this is not the case in the core of MP but is there are reason you are not using them? I would like to keep the coding style the same so people don't have issues fallowing the code but there are some places in the messaging that could benefit from using a service. So, would you rather I avoided them or it is a case of "haven't needed them yet"?

Also, if you don't mind I might be extending your workflow as well to allow other modules to hook into it. 

 

Thanks 

 

Jeff

2/23/2013 2:04:56 PM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: changes to core code?

Hi Jeff,

I prefer if you follow the same coding style. If you want to make a service on top of the business layer after the fact that's ok but I'm not a fan of making server side web requests when everything is running on the same server and the business objects can be accessed directly without that extra overhead.

I also prefer if things can still work when javascript is disabled but the experience can be enhanced by javascript but should be functional even with it disabled. Most things in ASP.NET WebForms do work even if javascript is disabled except for things like LinkButton or Autopostback on dropdown lists. So for example a feature could be built using the traditional webforms postback approach and it should be possible for it to work without javascript. But if you then want to dress it up with ajaxy javascript that calls services thats great so long as it can degrade and still be functional without it.

My advice is just work on and complete one thing to start. ie don't mess with workflow right now. If after private messaging is complete you want to do something with that we can consider it but the more wide ranging changes you propose at one time the less appealing and more distracting it is for me. 

Also I won't be able to even look at your code until I receive a contributor agreement. Note that the current pdf has an incorrect old address, I will see about updating it soon but the correct address to mail it to is PO Box 1978, Concord, NC 28026

Best,

Joe

 

2/24/2013 7:45:49 PM
Jeff Duty
Gravatar
Total Posts 30
View Posts
www.CSBA.org

Information Technologies, Resources and Services

California School Boards Association

Re: changes to core code?

Joe,

Thanks for the feedback. I am planning to follow your coding style, I see no reason to confuse people with random coding styles. I'll be sure to keep degradation in mind when working on anything I plan on sending your way. I'll only submit one module at a time. I'm doing most of this in my free time, so there might be pauses between modules. But to be honest most of this will neither be ground breaking or vastly complex, at least not at first.

As for the workflow, it's not for any of this. I only mention it in case you don't want it mucked with. I can create a module that other modules hook if needed. I just thought it would be odd have two WF systems. I don't have a choice, I have to have a workflow system for a couple projects, either way works for me.

I'll shoot the paper work your way soon. I have to get write off from work as well, I got verbal but not written and my boss is on vacation so it will be a week or two.

Jeff

 

 

 

You must sign in to post in the forums. This thread is closed to new posts.