LayoutDisplaySettings missing one property ?

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

Please do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.

This forum is for discussing mojoPortal development

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

You can monitor commits to the repository from this page. We also recommend developers to subscribe to email notifications in the developer forum as occasionally important things are announced.

Before posting questions here you might want to review the developer documentation.

Do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.
This thread is closed to new posts. You must sign in to post in the forums.
1/6/2013 1:18:19 PM
Ken Van Gilbergen
Gravatar
Total Posts 27
View Posts
https://ict.ken.be
Hybrid coding since
the dawn of time.

LayoutDisplaySettings missing one property ?

Hi,

I was looking at theme.skin and noticed that there are only 6 properties on LayoutDisplaySettings to customize the panels, while there are 7 possible combinations when using 3 panels. 

The one that is missing is the LeftAndRightNoCenter, was there a reason ?

It could be handy to have a 50%/50% split when no center, combined with a 20%/80%-80%/20% when there is a center and left or right.

K

ps: just realized that the 6 properties are only to style all possibilities with a center, we would need more to style no center possibilities.

1/7/2013 8:48:57 AM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: LayoutDisplaySettings missing one property ?

Hi,

I like these suggestions, especially the idea for 50%-50% 2 column layout using left and right, so I will add LeftAndRightNoCenterCss which will be applied to both side columns in the case where both side columns have content and center is empty. I will also add EmptyCenterCss so it can be hidden in that case and a boolean for HideEmptyCenterIfOnlySidesHaveContent so that the center div can be configured to not render at all in that case.

I will also add settings for LeftOnlyCss and RightOnlyCss, however they will be blank by default and will only be used in the case where it is not blank and when there is content only in one side. I don't want to change behavior of existing skins and I think users should use the center column if they want only 1 column, not left or right and in most cases it should be obvious to the user that they put the content in a side column even if the center is empty.

All of these settings will only be applied to the CmsPage ie Default.aspx so that it will not affect admin or edit pages.

Best,

Joe

1/7/2013 8:53:16 AM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: LayoutDisplaySettings missing one property ?

Keep in mind that the use of only left and right without center may have weird implications in the case where there is a vertical menu in the left side if 50% width is used. It could make the left menu appear inconsistent across pages with different layouts.

1/7/2013 2:00:45 PM
Ken Van Gilbergen
Gravatar
Total Posts 27
View Posts
https://ict.ken.be
Hybrid coding since
the dawn of time.

Re: LayoutDisplaySettings missing one property ?

That's  great, and this is exactly why I like your work so much.

Through the years I had to work for professional reasons with plenty of cms (like sharepoint, sitecore, drupal, wordpress, orchard, ...) And nothing beats mojoPortal. I now use it for almost all my personal projects.

I think it is mainly because you actually care for your product, and program it the way I program stuff. With passion and that makes the difference.

Thanks,

K

1/7/2013 2:28:46 PM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: LayoutDisplaySettings missing one property ?

I appreciate the great testimonial!

fyi, these changes are now in the source code repository.

Best,

Joe

You must sign in to post in the forums. This thread is closed to new posts.