If "Keep File History" is checked in the Shared Files Settings, I've notice the following:

1) When a Shared File is deleted, that file's corresponding history uploads do not also also delete from the Shared Files history folder on the server.

2) When deleting a Shared File folder, files inside that folder do not get deleted from the server (only the DB records).

Looking at the source code, I see that files only delete from the server if "Keep File History" is not checked.

Example:

if (!config.EnableVersioning)
                {
                    fileSystem.DeleteFile(VirtualPathUtility.Combine(fileVirtualBasePath, sharedFile.ServerFileName));
                }

Is that the expected behavior? or am I'm missing something?

Thanks.

Joe,

Thanks for the reply. I decided to make a copy of the Shared Files solution to alter.
In doing so, I began to understand the dilemma.

The solution I've come up with does a couple of things.

1) Folders:  If a folder contains other folders or files, then hide/disable the delete function for that folder until its contents are deleted.

2) Files:  If a file has history, then either:
                        a)  hide/disable its delete function until its history is deleted; or
                        b)  allow only specified role to delete files with history and/or create extra confirmation steps to delete. 

Though, I may take your suggestion to just flag a file as deleted and create a recovery page.
 

-- Jerry