By the way, this bug was fixed some time ago, but it reappeared recently. About a month ago, I downloaded the trunk version, installed it, and the prefilled content was missing!

May I humbly suggest that it would be cool to move all date-time management functionality into a separate class..

ulu

Hi Joe!

I've experienced same issues till found out my timezone was -4 instead of +3. By the way new two minor bugs were discovered in ContentManager (version 2.2.7.5 MSSQL).

The first one appears when content is already published and publication date is extracted from database and it is not adjusted from UTC to user's timezone. But when the user just saves publication settings this date is adjusted back to UTC as if it was user's local time. For me it works like substract 3 hours every time I save publication. But once someone has negative timezone offset acting this manner, the publication date will be increased by offset hours. So publication start date can even be in future for newly created content. The other side of the problem is publication end date which may be critical in some applications. And it is changed in the same manner.

The second bug: PageGuid of published content does not correspond to PageID in the mp_PageModules table. It seems like it is PageGuid of the first page of portal.

Regards,

Misha

Hi Joe,

But there is an error with ContentManager. Let me point it out.

Suppose we create new content. Next, add it to some page with begin time 10 a.m. We see time is adjusted to utc in the publishing table when we press "save". A little bit confusing, but ok. Next, open the publishing record we just added and see the begin time is not 10a.m. It's 7 a.m. for me (UTC+3).

Exactly the same thing happens with end date.

Let's look into the code.

Dates in the grid are placed in the dpBeginDate and dpEndDate date picker controls. dpBeginDate is bound to PublishBeginDate column using GetBeginDate(Eval("PublishBeginDate")). GetBeginDate looks like this
protected String GetBeginDate(Object o)
{
if((o == null)||(o.ToString() == String.Empty))
{
return DateTime.UtcNow.AddHours(timeOffset).ToString();
}

return o.ToString();

}
This function adjusts time only for empty value. This happens when content has not been published yet.
dpEndDate is bound to PublishEndDate using Bind("PublishEndDate").
When RowUpdating event occurs, DatePickers simply take their values from dpBeginDate and dpEndDate.
Are date adjusted before binding occurs? I’ve traced calls down to SQL. The answer is: no.

The fix is straightforward. But I’m not sure wether DateTime.Parse works ok if some cultures are mixed. But culture combinations are not supposed to happen, do they?

ContentManager.aspx.cs starting from line 268:
protected String GetBeginDate(Object o)
{
DateTime dt;
if ((o == null) || (o.ToString() == String.Empty))
dt = DateTime.UtcNow;
else dt = DateTime.Parse(o.ToString());

return ((DateTime)dt).AddHours(timeOffset).ToString();
}

protected String GetEndDate(Object o)
{
if ((o == null) || (o.ToString() == String.Empty))
return o.ToString();
return DateTime.Parse((string)o).AddHours(timeOffset).ToString();
}

ContentManager.aspx starting from line 65:
<asp:TemplateField HeaderText="">
<ItemTemplate>
<%# GetBeginDate(Eval("PublishBeginDate"))%>
</ItemTemplate>
<EditItemTemplate>
<mp:DatePickerControl id="dpBeginDate" runat="server" Text='<%# GetBeginDate(Eval("PublishBeginDate")) %>' ShowTime="True"></mp:DatePickerControl>
</EditItemTemplate>
</asp:TemplateField>
<asp:TemplateField HeaderText="">
<ItemTemplate>
<%# GetEndDate(Eval("PublishEndDate"))%>
</ItemTemplate>
<EditItemTemplate>
<mp:DatePickerControl id="dpEndDate" runat="server" Text='<%# GetEndDate(Eval("PublishEndDate")) %>' ShowTime="True"></mp:DatePickerControl>
</EditItemTemplate>
</asp:TemplateField>

Hope this helps mojoportal become little better. :)
Sincerely,
Misha