Missed upgrade

A place for discussion about skinning and design. Before posting questions here you should review the documentation about creating skins.

This thread is closed to new posts. You must sign in to post in the forums.
4/18/2011 10:15:52 AM
Gravatar
Total Posts 16

Missed upgrade

Hi

 

VS2010, sqlserver 2008,  windows7 /Windows Server 2008 .net framework 4

 

(mojoPortal mojoportal-2-3-6-5-mssql-net40-deploymentfiles)

And Source Code mojoportal-002ccdecaf37
(my VS2010 install is therefor version 2.3.6.6)

I must admit that i missed the upgrade towards the last two preceding versions of mojoPortal,
but the setup to the versions mentioned above, completed without any errors.

I have updated my skins to not use artisteer attribute in menus, upgraded
the themes to use the new format for artisteer menu. and my sites renders
fine, except i have a problem with the SearchResults page, and the printpreviewlink.

SearchResults.aspx has this script:

<script type="text/javascript">$('a[href*=Download.aspx]').bind('click', function(){window.open(this.href,'_blank');return false;});
</script>

(OpenSearchDownloadLinksInNewWindow = true, in webconfig)

but in jQuery 1.5.2 the [href*=Download.aspx] seems to fail with syntax error,
i dont know if its because of missing quotes arround the value Download.aspx.

 

also i noticed that skins without portal Scriptloader in head,
(like skin printerfriendly) now causes javascript error.

i dont know if mojoBasePage inserts the missing scriptloader,
but anyhow, the scripts are inserted after scripts that
invoke jQuery methods

from rendered html in skin printerfriendly, without scriptloader in head:

</body>
</html>

<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.5.2/jquery.min.js" type="text/javascript" ></script>
<script src="http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.11/jquery-ui.min.js" type="text/javascript" ></script>

i will work around this, by inserting the scriptloader in the head tag.

 

Best regards

Peter

4/18/2011 10:52:40 AM
Gravatar
Total Posts 18439

Re: Missed upgrade

Hi Peter,

You are right we should include ScriptLoader in the printerfriendly skin, I will do that going forward. All skins should include that. I don't think it is missing in any other skins we ship.

I'm not able to produce the script error you mentioned about search results, but if it is causing you a problem you can change back to an older version of jQuery by overriding these in user.config

<add key="GoogleCDNjQueryVersion" value="1.5.2"/>
<add key="GoogleCDNjQueryUIVersion" value="1.8.11"/>

you can specify older versions if you have any custom script that is not compatible with the latest jquery.

Best,

Joe

 

4/18/2011 11:32:03 AM
Gravatar
Total Posts 16

Re: Missed upgrade

Hi Joe

 

Thank You for Your answer.

Maybe i should start with a fresh install, something is happened on my site
 

I followed Your advice, and yes the exception is gone when i downgrade to  jQuery 1.4.4

when i use jQuery 1.5.x the exception is thrown.

I see the exception in MS-IE9 and Developer Extensions,

even when served from the server Firefox/ firebug shows:

uncaught exception: Syntax error, unrecognized expression: [href*=Download.aspx]

Best regards

Peter 

 

 

 

 

 

4/18/2011 11:44:16 AM
Gravatar
Total Posts 18439

Re: Missed upgrade

Hi Peter,

My bad, I had tried it on the demo site thinking it was using the new version of jquery but it was not. I was able to produce this error on my local machine using Firebug. putting single quotes in there seems to fix it, so I will be able to fix this for the next release but for now you could downgrade jquery. 

Best,

Joe

4/18/2011 11:57:38 AM
Gravatar
Total Posts 16

Re: Missed upgrade

Hi Joe

 

Thank You for Your answer.

Its all fine,  i just put 1.4.4 in the web.config.

Best regards

Peter

 

 

 

4/18/2011 12:08:20 PM
Gravatar
Total Posts 18439

Re: Missed upgrade

Its fixed now in the source code repository.

Best,

Joe

You must sign in to post in the forums. This thread is closed to new posts.