Missing Additional Meta Tags

This is the place to report bugs and get support. When posting in this forum, please always provide as much detail as possible.

Please do not report problems with a custom build or custom code in this forum. If you are producing your own build from the source code and have problems or questions, ask in the developer forum, do not report it as a bug.

This is the place to report bugs and get support

When posting in this forum, please try to provide as many relevant details as possible. Particularly the following:

  • What operating system were you running when the bug appeared?
  • What database platform is your site using?
  • What version of mojoPortal are you running?
  • What version of .NET do you use?
  • What steps are necessary to reproduce the issue? Compare expected results vs actual results.
Please do not report problems with a custom build or custom code in this forum. If you are producing your own build from the source code and have problems or questions, ask in the developer forum.
This thread is closed to new posts. You must sign in to post in the forums.
1/8/2007 1:15:50 PM
Gravatar
Total Posts 80

Missing Additional Meta Tags

The "Additional Meta Tags" from the SiteSettings page are not being added to HTML.

I added the following at line 114 to MetaContent.ascx.cs to fix the problem:

            metaAdditional = new Literal();
            if (currentPage.PageMetaAdditional.Length > 0)
            {
                metaAdditional.Text = currentPage.PageMetaAdditional;
            }
            else
            {
                metaAdditional.Text = siteSettings.MetaAdditional;
            }
            this.Controls.Add(metaAdditional);

Cheers,
Jesse
1/9/2007 4:06:42 AM
Gravatar
Total Posts 18439

Re: Missing Additional Meta Tags

Good catch. I will do the same change here.

Thanks,

Joe
1/9/2007 8:26:26 AM
Gravatar
Total Posts 18439

Re: Missing Additional Meta Tags

This is now fixed in svn branches/2.x

Thanks,

Joe
1/10/2007 12:52:21 PM
Gravatar
Total Posts 18439

Re: Missing Additional Meta Tags

fyi, I found that after this got fixed my site was no longer valid xhtml. Apparently arbitrary meta tags are not xhtml compliant so I removed the previous setting which was:
<meta Portal="mojoPortal" Version="2.1.1" />

and I'm setting the default to empty string for creating new sites.

I'm actually wondering if it would be better to remove the additional meta setting completely.

Thanks,

Joe
1/11/2007 4:00:43 AM
Gravatar
Total Posts 488

Re: Missing Additional Meta Tags

I think it is not nesessary to remove this setting - sometimes it still can be useful. But the default value should be an empty string, as you did it now.
1/11/2007 8:24:31 AM
Gravatar
Total Posts 80

Re: Missing Additional Meta Tags

It is useful for adding the below meta tags to discourage browsers from caching.  I vote the additional meta tags stays in.  If the user wants valid XHTML then it's their responsibility to make sure their meta tags are.

<meta http-equiv="Expires" content="-1"><meta http-equiv="Cache-Control" content="no-cache"><meta http-equiv="Pragma" content="no-cache">
You must sign in to post in the forums. This thread is closed to new posts.