Improvement blog

This is a forum to suggest new features for mojoPortal. 

This thread is closed to new posts. You must sign in to post in the forums.
1/15/2010 3:48:45 AM
Gravatar
Total Posts 171
I am a Russian programmer

Re: Improvement blog

Hi, Joe

I understand you. I agree. So, what I have written or will write, it only offers users of the mojoPortal.


I sent you translate help files into Russian

P.S.
And another improvement
On the form Administration Menu > Site Settings administrator can select the site logo. I think that also need to give him the opportunity to select background image from list.

Best regards, Alexander
 

1/17/2010 9:55:06 AM
Gravatar
Total Posts 171
I am a Russian programmer

Re: Improvement blog

Hi, Joe

LetterEdit.aspx.cs

private bool LetterIsValidForSending()

add

lblErrorMessage.Text = "";

Unsubscribe.aspx.cs

private void DoUnsubscribe()

after each subscriptions.Delete(s);

add

LetterInfo.UpdateSubscriberCount(s.LetterInfoGuid);

And you have to recalculate the number of subscribers!

Best regards, Alexander

1/18/2010 3:08:03 AM
Gravatar
Total Posts 171
I am a Russian programmer

Re: Improvement blog

Hi, Joe

mojoPortalLink.cs

protected override void Render(HtmlTextWriter writer)

string innerMarkup = "Powered by mojoPortal";

Please use the resource file instead of a constant value ("Powered by")

Best regards, Alexander

1/18/2010 7:06:01 AM
Gravatar
Total Posts 18439

Re: Improvement blog

Fixed in my copy.

Best,

Joe

1/19/2010 2:51:10 AM
Gravatar
Total Posts 171
I am a Russian programmer

Re: Improvement blog

Hi, Joe

You forgot to add LetterInfo.UpdateSubscriberCount(s.LetterInfoGuid);

if (subscriptionGuid != Guid.Empty)
{
LetterSubscriber s = subscriptions.Fetch(subscriptionGuid);
if (s == null)
{
ShowNotFoundMessge();
return;
}
subscriptions.Delete(s);

LetterInfo.UpdateSubscriberCount(s.LetterInfoGuid);

this.lblUnsubscribe.Text = Resource.NewsletterUnsubscribeSuccess;

btnUnsubscribeConfirm.Visible = false;
lblUnsubscribe.Visible = true;
return;
}
 

Best regards, Alexander
 

1/19/2010 8:13:38 AM
Gravatar
Total Posts 171
I am a Russian programmer

Re: Improvement blog

Hi, Joe

If the module to include a blog comment and then enter a comment containing a link or smile that the link (or smile) does not appear on the site

Best regards, Alexander

1/19/2010 11:23:52 AM
Gravatar
Total Posts 171
I am a Russian programmer

Re: Improvement blog

Oh, next mistake

SiteSettings.aspx.cs

private void PopulateControls()

change

tabHosts.Visible = false;
tabFolderNames.Visible = false;
 

to

tabHosts.Visible = false;
liHosts.Visible = false;
tabFolderNames.Visible = false;
liFolderNames.Visible = false;

Best regards, Alexander
 

1/19/2010 12:52:45 PM
Gravatar
Total Posts 18439

Re: Improvement blog

Thanks!

Best,

Joe

1/20/2010 12:00:09 PM
Gravatar
Total Posts 171
I am a Russian programmer

Re: Improvement blog

StyleSheetCombiner.ascx.cs

private void SetupjQueryUICss()

change

string jQueryUIVersion = "1.7.1";
if (ConfigurationManager.AppSettings["GoogleCDNjQueryVersion"] != null)
{
  jQueryUIVersion = ConfigurationManager.AppSettings["GoogleCDNjQueryUIVersion"];
}
 

to

string jQueryUIVersion = "1.7.2";
if (ConfigurationManager.AppSettings["GoogleCDNjQueryUIVersion"] != null)
{
jQueryUIVersion = ConfigurationManager.AppSettings["GoogleCDNjQueryUIVersion"];
}
 

 

ScriptLoader.cs

private string GetJQueryUIBasePath()

string jQueryUIVersion = "1.7.1";

to

string jQueryUIVersion = "1.7.2";

Best regards, Alexander
 

9/28/2011 4:03:54 PM
Gravatar
Total Posts 13

Re: Improvement blog

Here's some nice and typical mojoPortal-style source code to understand in what programming conditions the author is. I think it must be read before asking Joe Audette to fix something.

mojoBasePage.cs

// Author:             Joe Audette
// Created:            2006-01-07
// Last Modified:      2011-07-31

//...

protected void SetupWorkflowControls()

{
    if (
                (WebConfigSettings.EnableContentWorkflow && siteSettings.EnableContentWorkflow)
                    && (
                    (WebUser.IsInRoles(CurrentPage.DraftEditOnlyRoles)) || (WebUser.IsInRoles(CurrentPage.EditRoles))
                    )
                )
            {

                viewMode = GetUserViewMode();

                if ((WebConfigSettings.EnableContentWorkflow) && (siteSettings.EnableContentWorkflow)) // brilliant!
                {

                     //...

                 }

 //...

}

Would you like a coffee instead of beer, Joe? Короче говоря, mojoPortal скоро может быть погребен под горами подобного креатива. Полностью переписывать придется, либо отправлять на свалку.

9/28/2011 4:30:33 PM
Gravatar
Total Posts 18439

Re: Improvement blog

ok, I'm not perfect and that isn't the prettiest code there because there are some redundant check of conditions. mojoPortal is a large project, some code is nicer than other code, you start with code that works and as time permits you make things cleaner, its a process. I suppose all code you ever wrote is very pretty.  But you make a big deal about a small thing and stir up this old thread so welcome to the list of trolls I will ignore. Criticism is the easiest thing in the world to produce, I've got a good supply of it myself and don't really need yours.

Do you just enjoy stirring up trouble? Or maybe you are mad because I did not respond to your idea about that silly wikify service. I really don't see any need to generate wikipedia links for my content, if I want to link to something I just link to it.  If you don't like my work just don't use it and go away and build your own CMS.

You must sign in to post in the forums. This thread is closed to new posts.